Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aria-label class not properly hidden (fixes #606) #611

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Fix: aria-label class not properly hidden (fixes #606) #611

merged 4 commits into from
Feb 12, 2025

Conversation

hanshillen
Copy link
Contributor

fixes #606

Fix

oliverfoster
oliverfoster requested changes Jan 7, 2025
View reviewed changes
oliverfoster
oliverfoster approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 looks good

kirsty-hames
kirsty-hames reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks @hanshillen but I've added some comments for your input please.

@hanshillen
Copy link
Contributor Author

I've addressed the requested changes.

kirsty-hames
kirsty-hames approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍

@kirsty-hames kirsty-hames mentioned this pull request Feb 4, 2025
Open
guywillis
guywillis approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster
Copy link
Member

@cahirodoherty-learningpool would you mind +1ing please?

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 951e6c0 into adaptlearning:master Feb 12, 2025
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
@semantic-release-bot
Chore(release): 6.60.8
230a2fa 
## [6.60.8](v6.60.7...v6.60.8) (2025-02-12)

### Fix

* aria-label class not properly hidden (fixes #606) (#611) ([951e6c0](951e6c0)), closes [#606](#606) [#611](#611)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.60.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames kirsty-hames mentioned this pull request Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@hanshillen hanshillen

Labels
bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aria-label class not properly hidden
5 participants
@hanshillen @oliverfoster @kirsty-hames @guywillis @cahirodoherty-learningpool