From c15c9f1a65d3ad35e08ee00d06b8ec92f9057bfb Mon Sep 17 00:00:00 2001 From: Oliver Foster Date: Sat, 13 May 2023 16:53:41 +0100 Subject: [PATCH 1/2] Fix: Match columns to breakpoints --- less/project/columns.less | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/less/project/columns.less b/less/project/columns.less index 422e087c..48afaa7f 100644 --- a/less/project/columns.less +++ b/less/project/columns.less @@ -16,8 +16,8 @@ // min small viewport takes up 8 out of 12 columns // min medium viewport takes up 10 columns // if undefined element defaults to 100% width -.make-columns(xs, 0, 12); -.make-columns(sm, @device-width-small, 12); +.make-columns(xs, @device-width-small, 12); +.make-columns(sm, 400, 12); .make-columns(md, @device-width-medium, 12); .make-columns(lg, @device-width-large, 12); -.make-columns(xl, @max-page-width, 12); +.make-columns(xl, @device-width-xlarge, 12); diff --git a/package.json b/package.json index 0d7d51b3..aed702e8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "adapt-contrib-vanilla", "version": "9.6.11", - "framework": ">=5.24.2", + "framework": ">=5.31.3", "homepage": "https://github.com/adaptlearning/adapt-contrib-vanilla", "bugs": "https://github.com/adaptlearning/adapt-contrib-vanilla/issues", "theme": "vanilla", From 829b388fb578115046aedbdfa31a5206b1341df3 Mon Sep 17 00:00:00 2001 From: Oliver Foster Date: Mon, 15 May 2023 10:40:31 +0100 Subject: [PATCH 2/2] Recommendations --- less/project/columns.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/less/project/columns.less b/less/project/columns.less index 48afaa7f..49b0de9d 100644 --- a/less/project/columns.less +++ b/less/project/columns.less @@ -16,8 +16,8 @@ // min small viewport takes up 8 out of 12 columns // min medium viewport takes up 10 columns // if undefined element defaults to 100% width -.make-columns(xs, @device-width-small, 12); -.make-columns(sm, 400, 12); +.make-columns(xs, 0, 12); // deprecated: backward compatibility only +.make-columns(sm, @device-width-small, 12); .make-columns(md, @device-width-medium, 12); .make-columns(lg, @device-width-large, 12); .make-columns(xl, @device-width-xlarge, 12);