Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.64 has removed prop-types which are **required** for react v16 compatibility #991

Closed
Michael-Tajmajer-Emrsn opened this issue Oct 24, 2017 · 2 comments

Comments

@Michael-Tajmajer-Emrsn
Copy link

I diffed the 2.0.64 changes and was extremely disappointed that the references to prop-types, which are needed for react v16 compatibility were removed.

Why are you moving the project farther away from v16?

From: https://reactjs.org/blog/2017/09/26/react-v16.0.html

The deprecations introduced in 15.x have been removed from the core package. React.createClass is now available as create-react-class, React.PropTypes as prop-types, React.DOM as react-dom-factories, react-addons-test-utils as react-dom/test-utils, and shallow renderer as react-test-renderer/shallow. See 15.5.0 and 15.6.0 blog posts for instructions on migrating code and automated codemods.

@Michael-Tajmajer-Emrsn Michael-Tajmajer-Emrsn changed the title 2.0.64 has removed prop-types which is *reqyuired* for react v16 compatability 2.0.64 has removed prop-types which are **required** for react v16 compatibility Oct 24, 2017
@amanmahajan7
Copy link
Contributor

This does not seem correct. PR (#954) migrated React.PropTypes to separate prop-types package and was merged yesterday.

@Michael-Tajmajer-Emrsn
Copy link
Author

You are correct!
I misread the diff -- sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants