You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seems odd given query is the runtime dependency. If it really is needed then it should be added to the dependencies of @pgtyped/query currently it's only available because it's in devDependencies of the root project.
It looks like the generator is the only thing that uses parseTypescriptFile abd parseSQLFile. Perhaps they should be refactored out of query?
The text was updated successfully, but these errors were encountered:
Good point, query is currently both a runtime and a compile-time dependency for PgTyped.
query/loader parsing routines are used both in the query package (in the preprocessor) and in the cli package (in generators). That is why I initially had to move loaders and parsers to query.
I have added TS as a peer dep for @pgtyped/query here #88, but we should definitely plan to split the runtime and compile-time components of it at some point.
I was producing a production build with
yarn install --production
and noticed @pgtyped/query pulls inTypescript
https://github.com/adelsz/pgtyped/blob/master/packages/query/src/index.ts#L13.This seems odd given
query
is the runtime dependency. If it really is needed then it should be added to thedependencies
of@pgtyped/query
currently it's only available because it's indevDependencies
of the root project.It looks like the generator is the only thing that uses
parseTypescriptFile
abdparseSQLFile
. Perhaps they should be refactored out of query?The text was updated successfully, but these errors were encountered: