Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat certain source files for usability #49

Open
BobBolch opened this issue Nov 27, 2020 · 5 comments
Open

Reformat certain source files for usability #49

BobBolch opened this issue Nov 27, 2020 · 5 comments
Labels
enhancement New feature or request in-progress Being worked on

Comments

@BobBolch
Copy link
Collaborator

Certain C files in the BREXX source have extremely long records. They are not easiliy usable on CMS. One example is INTERPRE.C which is 190 bytes wide. Please reformat these files to have a maximum record length of 130 bytes or less (preferably around 80 bytes or so) so they can be more usable on 3270 terminals. These lines might be more understandable if they were broken down into more than one line of logic.

Bob Bolch

@adesutherland adesutherland added the enhancement New feature or request label Nov 27, 2020
@adesutherland
Copy link
Owner

I will run all the code through a beautifier (inc GCCLIB)

@adesutherland
Copy link
Owner

Fixed in F0032 (and also in GCCLIB F0047)

@adesutherland adesutherland added the Ready 4 Test Item is ready for testing in its feature branch label Dec 13, 2020
@BobBolch
Copy link
Collaborator Author

Could address.c and errortxt.c have their record lengths reduced also?
I meant to request all source files > 132 bytes, so maybe that wasn't clear.
Bob

@adesutherland
Copy link
Owner

I made some changes and now the code wrapped with #ifdef CMS is handled.

(Done in F0035)

However it does not seem to fix long string literals - so these will need to be done manually :-(

@adesutherland adesutherland removed the Ready 4 Test Item is ready for testing in its feature branch label Dec 13, 2020
@adesutherland
Copy link
Owner

Need to manually fix up the remaining offending files

@adesutherland adesutherland added the in-progress Being worked on label Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Being worked on
Projects
None yet
Development

No branches or pull requests

2 participants