-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translator crashes when supplied reader doesn't exist. #10
Comments
Fixed. But I did make some changes to the response object. I changed 'readerNameRequested' and 'readerName' to 'readerRequested' and 'readerFound'. I also set 'writerPass' to false if no writer was specified. Messages were added to both reader and write for 'Reader/Writer name is missing or not supported'. |
@stansmith907 Shouldn't the messages always be an array? They're returning a string, at least for single errors. |
Yes. Let me see what I did. |
Fixed and pushed as version 0.10.1. Maybe we need to write some test scripts! |
Yeah, I actually was adding a simple test for 19110 when I found the problem. |
OK, I'll try your 1 a week idea. |
Patched mdTranslator to catch missing and nil reader and writer names. |
Is this expected behavior, or should we provide a more useful error message?
The error output is:
The text was updated successfully, but these errors were encountered: