Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure if non-semantic version is supplied #11

Closed
jlblcc opened this issue Dec 4, 2014 · 1 comment
Closed

Failure if non-semantic version is supplied #11

jlblcc opened this issue Dec 4, 2014 · 1 comment
Labels
bug Unexpected problem or unintended behavior enhancement Improve or modify an existing feature

Comments

@jlblcc
Copy link
Member

jlblcc commented Dec 4, 2014

A non-semantic version, e.g. 1 causes a failure:

TypeError: no implicit conversion of nil into String
 .../Projects/ADIwg/adiwgTranslator/mdTranslator/lib/adiwg/mdtranslator/readers/mdJson/mdJson_validator.rb:72:in `+' 

.../Projects/ADIwg/adiwgTranslator/mdTranslator/lib/adiwg/mdtranslator/readers/mdJson/mdJson_validator.rb:72:in `validate'
@jlblcc jlblcc added bug Unexpected problem or unintended behavior enhancement Improve or modify an existing feature labels Dec 4, 2014
@jlblcc
Copy link
Member Author

jlblcc commented Dec 4, 2014

I patched MdJsonValidation to at least make sure the version is three parts when split on "."

@jlblcc jlblcc closed this as completed in 2972d8b Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior enhancement Improve or modify an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant