Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbJSON itemLink associationType not translated #137

Closed
jlblcc opened this issue Sep 14, 2017 · 2 comments
Closed

sbJSON itemLink associationType not translated #137

jlblcc opened this issue Sep 14, 2017 · 2 comments
Labels
bug Unexpected problem or unintended behavior reader:sbJson writer:mdJson

Comments

@jlblcc
Copy link
Member

jlblcc commented Sep 14, 2017

It appears the itemLink associationTypes are not making it through the translation.

Example SB item:https://www.sciencebase.gov/catalog/item/5542394be4b0a658d793b55a

@jlblcc jlblcc added bug Unexpected problem or unintended behavior reader:sbJson writer:mdJson labels Sep 14, 2017
@stansmith907
Copy link
Contributor

Yep, I see that I postponed this section because it was (is) a PINA and forgot to place a TODO tag. I just skipped it. Anyway, in there now.

Here are few item to contemplate...

  • remember these do not go back into sbJson through the sbJson writer. The writer ignores building relatedItems, thus associated resources.
  • There are two sbJson linkTypes we cannot translate; copyFrom/copyInto, precededBy/succeededBy. I just moved these values into the translator as is. However these were not added to the codelist.
  • All associations entered into the translator are expressed as forward relationships. To accomplish this any sbJson reverse relationships are reversed by the reader.
  • If sbJson link.type is missing or empty the association type is set to 'missing' since the associationType is required.

@jlblcc
Copy link
Member Author

jlblcc commented Sep 15, 2017

That all sounds fine to me. Yeah, writing associated items to ScienceBase is outside the scope. That will have to be handled by some kind of middle-ware. Definitely not interested in going beyond anything besides GET requests.

@jlblcc jlblcc closed this as completed in d9b66ef Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior reader:sbJson writer:mdJson
Projects
None yet
Development

No branches or pull requests

2 participants