Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdJSON reader version is stale #158

Closed
jlblcc opened this issue Nov 3, 2017 · 8 comments
Closed

mdJSON reader version is stale #158

jlblcc opened this issue Nov 3, 2017 · 8 comments
Assignees
Labels
bug Unexpected problem or unintended behavior reader:mdJson

Comments

@jlblcc
Copy link
Member

jlblcc commented Nov 3, 2017

The mdJSON reader version is out of date (2.2.0). It fails with the current version of mdJSON(2.3.2).

Might be a good idea to write a test that compares to the schema version in the gemspec.

@jlblcc jlblcc added bug Unexpected problem or unintended behavior reader:mdJson labels Nov 3, 2017
@stansmith907
Copy link
Contributor

True, I should have updated the mdJson reader version. But the version number being out of sync with the schema should not cause a failure, the reader version is comment only - the reader is not loaded external to the entire mdTranslator.

The two version numbers cannot be synced either. The mdJson reader version will naturally be ahead of the schema version. The test should verify the reader version is greater than to equal the schema version.

That said, what's failing? And am I missing something?

@jlblcc
Copy link
Member Author

jlblcc commented Nov 3, 2017

It was failing for me when reading mdJSON, version set to 2.3.2

@stansmith907
Copy link
Contributor

stansmith907 commented Nov 3, 2017

Can you be more specific? I have 37 places in tests I have stepped around schema validation because the schema does allow the new fields recently added. Also, I just made the domainItems array optional rather than required. I didn't think any of these changes would impact older versions of mdJson, but maybe!

Are all your jobs failing? Or just one?

@jlblcc
Copy link
Member Author

jlblcc commented Nov 3, 2017

I get a readerStructureMessage: mdJson schema version '2.3.0' is not supported

@jlblcc
Copy link
Member Author

jlblcc commented Nov 3, 2017

It's failing due to the schema version set in the mdJSON.

@stansmith907
Copy link
Contributor

Ah! So I am testing mdJson file's mdJson.schema.version against the mdJson reader VERSION. I must be slipping, can't remember what I coded a year and a half ago.

The tests only check single sections at a time. I'll need to work this into the testing sequence. Have it by this weekend. In the meantime, you can always set the mdJson schema version back to 2.2 in your files.

@jlblcc
Copy link
Member Author

jlblcc commented Nov 3, 2017

I can't remember what I coded two weeks ago! 🙄

Yep, I just set the version back for now.

@stansmith907
Copy link
Contributor

Patched. I'll issue a PR for mdTranslator version 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior reader:mdJson
Projects
None yet
Development

No branches or pull requests

2 participants