Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbJson 2.0 budget facet #77

Closed
stansmith907 opened this issue Mar 24, 2017 · 3 comments
Closed

sbJson 2.0 budget facet #77

stansmith907 opened this issue Mar 24, 2017 · 3 comments

Comments

@stansmith907
Copy link
Contributor

elements matching (Boolean) and recipient (string) are not yet in the sbJson schema. We will carry these anyway.

@jlblcc
Copy link
Member

jlblcc commented Apr 6, 2017

Here's the latest budget facet example:

  "facets": [{
    "annualBudgets": [{
      "fundingSources": [{
        "amount": 250.0,
        "matching": true,
        "recipient": "Bar",
        "source": "Foo"
      }, {
        "amount": 250.0,
        "matching": false,
        "recipient": "Baz",
        "source": "Biz"
      }],
      "year": "2017"
    }, {
      "fundingSources": [{
        "amount": 100.0,
        "matching": null
      }],
      "year": "2016"
    }, {
      "year": "2015"
    }, {
      "fundingSources": [{
        "amount": 100.0,
        "matching": null
      }],
    }],
    "className": "gov.sciencebase.catalog.item.facet.BudgetFacet"
  }]

@stansmith907
Copy link
Contributor Author

Use fiscal federal year beginning October 1.
Use period endDateTime if available, startDateTime if not.

@stansmith907
Copy link
Contributor Author

Recipient and source in sbJson are text and in mdJson contactId(s). In the sbJson writer we just moved the contactId(s) into the sbJson text fields. But in the sbJson reader the text will not be valid mdJson contactId(s). Do we want to attempt to search the contact array for contact names matching the text? or ignore recipient and source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants