Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support public.skipExportGlyphs in font.info #1082

Open
benkiel opened this issue Jan 25, 2020 · 7 comments
Open

Support public.skipExportGlyphs in font.info #1082

benkiel opened this issue Jan 25, 2020 · 7 comments

Comments

@benkiel
Copy link
Contributor

benkiel commented Jan 25, 2020

Could makeotf support the public.skipExportGlyphs in font.info? See discussion of it here: unified-font-object/ufo-spec#84 (and, yes, we need to add this to defcon still...)

@josh-hadley
Copy link
Collaborator

Could you elaborate a bit on how you'd like to see this supported in makeotf (or elsewhere in AFDKO)?

@benkiel
Copy link
Contributor Author

benkiel commented Feb 11, 2020

@josh-hadley Sorry for the slow reply. In brief, it would be great if makeotf would look for public.skipExportGLyphs if it ingests a UFO and if present it removes those glyphs from the generated OTF after decomposing the UFO.

@frankrolf
Copy link
Member

I am curious how this would correspond with the GlyphOrderAndAliasDB’s -gs option (which excludes glyphs not mentioned within).
Which of the two methods would take precedence?

@benkiel
Copy link
Contributor Author

benkiel commented Feb 12, 2020

Hmmmmm, that's a fair point. Use case for this in makeOTF is likely low, so feel free to close.

@miguelsousa
Copy link
Member

Which of the two methods would take precedence?

The option would take precedence over the key. I think it's the approach we've taken in other comparable cases. See #765 (comment)

@josh-hadley
Copy link
Collaborator

If/when we implement this, we should be sure to document which takes precedence and maybe issue a warning at runtime when both the public.skipExportGlyphs key and GOADB with -gs option are specified to avoid users making the wrong assumption.

@twardoch
Copy link

twardoch commented Apr 2, 2020

My view is that since skipExportGlyphs travels with the font source, it really is informative about what constitutes the "full glyph repertoire" of the final font. The glyphs in skipExportGlyphs are simply "not intended" to be included in the binary font at all.

The -gs option is a positive filter for creating subsets, kind of equivalent to pyftsubset.

But I agree that the -gs option should take precedence and "turn off" skipExportGlyphs because there is a valid use case that you may want to include the otherwise skipped glyphs in GOADB.

Basically, in a UFO worfklow, GOADB is a mechanism for overriding specifications found in the UFO — glyph set, glyph names Unicode codepoint assignments. Right? So it always "turns off" an aspect present in the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants