-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support public.skipExportGlyphs
in font.info
#1082
Comments
Could you elaborate a bit on how you'd like to see this supported in |
@josh-hadley Sorry for the slow reply. In brief, it would be great if |
I am curious how this would correspond with the GlyphOrderAndAliasDB’s |
Hmmmmm, that's a fair point. Use case for this in makeOTF is likely low, so feel free to close. |
The option would take precedence over the key. I think it's the approach we've taken in other comparable cases. See #765 (comment) |
If/when we implement this, we should be sure to document which takes precedence and maybe issue a warning at runtime when both the |
My view is that since skipExportGlyphs travels with the font source, it really is informative about what constitutes the "full glyph repertoire" of the final font. The glyphs in skipExportGlyphs are simply "not intended" to be included in the binary font at all. The -gs option is a positive filter for creating subsets, kind of equivalent to pyftsubset. But I agree that the -gs option should take precedence and "turn off" skipExportGlyphs because there is a valid use case that you may want to include the otherwise skipped glyphs in GOADB. Basically, in a UFO worfklow, GOADB is a mechanism for overriding specifications found in the UFO — glyph set, glyph names Unicode codepoint assignments. Right? So it always "turns off" an aspect present in the source file. |
Could
makeotf
support thepublic.skipExportGlyphs
infont.info
? See discussion of it here: unified-font-object/ufo-spec#84 (and, yes, we need to add this todefcon
still...)The text was updated successfully, but these errors were encountered: