Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] Misleading error for lookup blocks before languagesystem #966

Open
khaledhosny opened this issue Sep 21, 2019 · 0 comments
Open
Assignees

Comments

@khaledhosny
Copy link
Collaborator

The following file causes makeotfexe to fail with:

makeotfexe [WARNING] <font> [internal] Feature block seen before any language system statement. You should place languagesystem statements before any feature definition [a.fea 1]
makeotfexe [ERROR] <font> languagesystem must be specified before all feature blocks [a.fea 5]
makeotfexe [FATAL] <font> aborting because of errors
lookup a {
    sub a by a;
} a;

languagesystem latn dflt;

feature liga {
    lookup a;
} liga;

But there are no features before the languagesystem statement so the message is misleading. The spec only mentions feature blocks too. So either the spec or the code need to be updated to match the other.

@khaledhosny khaledhosny changed the title Misleading error for lookup blocks before languagesystem [makeotfexe] Misleading error for lookup blocks before languagesystem Sep 21, 2019
@readroberts readroberts self-assigned this Oct 1, 2019
@cjchapman cjchapman added the high priority important but not urgent label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants