You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FontTools has a test that uses such empty glyph classes that was added in fonttools/fonttools#1318 (by me, though I have no recollection if having ever written this code and has no idea whatsoever what real world issue I was trying to fix).
I can't find anywhere in the feature file spec that currently says glyph classes should not be empty. Can you point me to this? I would normally have a mild preference for disallowing this, as it seems like something that could be done by accident, and it is useful to let users know that something odd is in the file. However, I do see that allowing an empty glyph class allows developers create at least one useful test case. In fonttools/fonttools#1318, Khaled used this feature to create a class kern pair subtable with a null Coverage offset, which is useful in testing that the feaLib code weeds this out in order to avoid an error in OTS. This seems useful enough to me to justify the functionality. I vote allow to allow empty glyph classes in the feature file, with a note that this is supported in order to allow building test cases, and that any implementation needs to suppress any resulting empty Coverage tables, and suggesting that a warning be issued.
The following feature file causes an error with makeotf but is accepted by feaLib:
makeotf error:
The spec does not seem to explicitly disallow empty glyph classes.
The text was updated successfully, but these errors were encountered: