fix: conditionally add async tag in page editor clientlibs #19

rachitkumar13 · 2020-09-14T07:30:34Z

No description provided.

codecov · 2020-09-14T07:33:14Z

Codecov Report

Merging #19 into master will increase coverage by 0.84%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   90.83%   91.67%   +0.84%     
==========================================
  Files          10       11       +1     
  Lines         622      685      +63     
  Branches      169      182      +13     
==========================================
+ Hits          565      628      +63     
  Misses         56       56              
  Partials        1        1

Impacted Files	Coverage Δ
src/AuthoringUtils.ts	`100.00% <100.00%> (ø)`
src/Constants.ts	`95.65% <100.00%> (+5.65%)`	⬆️
src/MetaProperty.ts	`85.71% <100.00%> (+2.38%)`	⬆️
src/ModelClient.ts	`95.23% <100.00%> (+0.50%)`	⬆️
src/ModelManager.ts	`86.47% <100.00%> (+0.16%)`	⬆️
src/PathUtils.ts	`96.13% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d2f4f...eed084c. Read the comment docs.

src/ModelManager.ts

src/ModelClient.ts

src/ModelManager.ts

src/Utils.ts

src/Constants.ts

src/Utils.ts

src/ModelClient.ts

src/ModelManager.ts

src/Utils.ts

CezCz · 2020-09-16T07:46:50Z

src/Utils.ts

+        let tags = '';
+        if (state === Constants.AUTHORING) {
+            const clientLibs = this.generateClientLibsUrl();
+            clientLibs.forEach(clientlib => {


I think it would be cool if we changed the forEach to map and return the tags, this way we have no side effect

src/Utils.ts

src/ModelClient.ts

grubyak · 2020-09-16T19:20:55Z

@rachitkumar13 i have updated github actions (your branch is basing on very old master) and while sonar check is now passing, codecov still requires better coverage, see https://github.com/adobe/aem-spa-page-model-manager/pull/19/checks?check_run_id=1124975929

missing tests for:

Utils#getEditParam
Utils#getDomain
PathUtils#getCurrentURL

src/Utils.ts

grubyak · 2020-09-21T08:29:39Z

.github/workflows/ci.yml

+            -Dsonar.sources=src
+            -Dsonar.tests=test
+            -Dsonar.javascript.lcov.reportPaths=coverage/lcov.info


i fixed here sonar code coverage reports

sonarqubecloud · 2020-09-22T14:39:25Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

CezCz

Test

# [1.1.0](v1.0.3...v1.1.0) (2020-09-22) ### Features * conditionally add async tag in page editor clientlibs ([#19](#19)) ([9c3e86b](9c3e86b))

github-actions · 2020-09-22T15:57:49Z

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Rachit Kumar added 2 commits September 14, 2020 12:54

fix: conditionally add async tag in page editor clientlibs

992873a

fix: conditionally add async tag in page editor clientlibs

ba297e1

rachitkumar13 commented Sep 14, 2020

View reviewed changes

src/ModelManager.ts Outdated Show resolved Hide resolved