Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Core][Quick Docs]: Links on the Quick Docs pane for property Background are incorrect. #4763

Closed
julieyuan opened this issue Aug 13, 2013 · 10 comments
Assignees
Labels

Comments

@julieyuan
Copy link

Steps:

  1. Launch Brackets and open a CSS file.
  2. Put the cursor behind the property background and press Ctrl+K to open Quick Docs.
  3. Click all the links on the Quick Docs pane. Then hover the mouse on the links.

Result:
After clicking the links, it will show that the property is not found. When hover the mouse on the links on the Quick Docs pane, it will show that the URLs is incorrect.

Expected:
After step3, it should redirect to the correct page to show the corresponding property.

ENV: MAC10.8.3 and Win8 English OS
Build: 0.29.0-8678

Snapshots:
Please refer to snapshots for details:
After step3, it will redict to this not found page:
4
Incorrect URL:
2
Correct URL for reference:
3

@julieyuan
Copy link
Author

I think this issue maybe also happens to other links which are on the Quick Docs pane. Just saw this also happening to link flex related to property display.

@njx
Copy link

njx commented Aug 13, 2013

Doesn't seem to be an issue for some other properties with shorthands (like border), so this might just be a problem with a few cases.

@ghost ghost assigned pthiess Aug 13, 2013
@njx
Copy link

njx commented Aug 13, 2013

To @pthiess to track for now.

@awgreenblatt
Copy link

The problem is in www/extensions/default/WebPlatformDocs/css.json

For some reason, in some cases double quotes (") are escaped as " where they should be simply backslash-escaped, as in \"
I changed css.json locally to test this out, changed the links in background's description and it works fine. There are probably other properties that have the same issue.

@peterflynn
Copy link
Member

Sounds very similar to #4342...

@julieyuan
Copy link
Author

Found another links issue today for property animation-timing-function. The links on its Quick Docs pane are also not correct. They redirect to upload picture page instead of corresponding picture. Here is the snapshot:
10

@pthiess
Copy link
Contributor

pthiess commented Sep 16, 2013

@julieyuan - If possible please verify if this is fixed.

@julieyuan
Copy link
Author

Checked this issue with build 0.32.0-9586. It still reproduces.

@ghost ghost assigned pthiess Sep 22, 2013
@iwehrman
Copy link
Contributor

Does #5044 change this?

@julieyuan
Copy link
Author

This issue is fixed with build 0.33.0-9858. So closing it. Here are snapshots for reference:
fix1
fix2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants