Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

File Icons #4796

Open
ghost opened this issue Aug 16, 2013 · 15 comments
Open

File Icons #4796

ghost opened this issue Aug 16, 2013 · 15 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 16, 2013

Love Brackets, but at the current time, setting Brackets to open a specific file type makes the file's icon turn into the boring white document icon. Perhaps a set of icons for when Brackets is the default opener for a file type...?

@JeffryBooher
Copy link
Contributor

@GymbylCoding are you seeing this on Mac, Windows or Linux? Also what version? I tried with Windows 8 and Mac 10.8.4 and I do get a Brackets related icon for the file types I associate with Brackets.

On the Mac, I think they all start out as generic Document icons but you can make All js files open in Brackets by option+clicking on a js file then choosing "Get Info" and then change the default "Open With" application to Brackets then click the "Change All..." button. At that point all js files will have a Brackets document icon.

On Windows, we just added support for "Open With..." integration in Windows Explorer. With Sprint 30 on Windows 8, I see the Brackets icon when I choose "Open With" on a js file and select "Choose Default Program" then select Brackets Sprint 30. Previously you had to browse and locate the installed version of Brackets you wanted to use to open the file.

I haven't tried Linux yet but that's so new that I don't think icons are ready yet.

Let me know how you changed to make Brackets the default program for a specific file type and I will check it out.

@TuckerWhitehouse
Copy link
Contributor

@JeffryBooher I am experiencing this issue as well.

Mac OS X 10.8.4
Building brackets from source (if that makes a difference).

My JS files were already defaulting to brackets (and display a white blank document icon), but I followed the steps you listed to change my .html files to open in brackets, and they too now display with generic blank white document icons.

@JeffryBooher
Copy link
Contributor

@TuckerWhitehouse Can you try installing Brackets Sprint 29 and let me know if you see that problem as well? It shouldn't matter but you never know :)

@ghost
Copy link
Author

ghost commented Aug 16, 2013

Using Brackets Sprint 29 on Mac.

I am mostly using .lua files, if that makes a difference, but the .js files are doing the same thing.

Changed to default application thus: Get Info > Open With > Brackets Sprint 29 > Change All... > Changed.

Still have a white document icon.

Caleb

@gruehle
Copy link
Member

gruehle commented Aug 26, 2013

Marking "move to backlog". We should have custom document icons for file types recognized by Brackets.

@peterflynn
Copy link
Member

@TuckerWhitehouse Installed vs. built from source does make a difference on Windows. The installer registers Brackets for the "Open With" right-click listing, which may also play a role in file icon selection.

@TuckerWhitehouse
Copy link
Contributor

@peterflynn I'm on OSX, does it make a difference there?

@ghost ghost assigned JeffryBooher Aug 29, 2013
@pthiess
Copy link
Contributor

pthiess commented Aug 29, 2013

@JeffryBooher - please investigate, we suspect there is just a bug.

@gruehle
Copy link
Member

gruehle commented Aug 29, 2013

@JeffryBooher - Can you take screenshots of Mac, Windows (and Linux, if possible) so we can see what the "default" icons look like? I'm still seeing the generic icon on the Mac, but I have a bunch of different builds installed, so it's likely that my OS is just getting confused.

Once we have screenshots, @larz0 can determine if we should create custom document icons.

@JeffryBooher
Copy link
Contributor

Sorry, I forgot about this. I captured the images but didn't do linux. I don't know if linux really matters right now anyway

brackets_document_icon_windows
brackets_document_icon

@ghost ghost assigned larz0 Sep 16, 2013
@JeffryBooher
Copy link
Contributor

Assigning this to @larz0

@danvim
Copy link

danvim commented Nov 2, 2014

Using Release 0.44, icons became blank documents. It was better when it showed the brackets logo.

@Lomacar
Copy link

Lomacar commented Apr 11, 2015

In Brackets 1.2 on Windows 7 I have plain document icons for files that are supposed to be opened by Brackets by default.

@MLCozad
Copy link

MLCozad commented May 12, 2015

For the mac.
Make up a doc-icon. The Bracket icon, with a page outline, saved as a png converted to .icns, label it BracketsDoc.icns.
Select the Brackets.app icon, open the package content.
In the content folder, open the Resource folder and put in the icns file.
Open the info.plist file in the content folder.
Select Document types, select a type, example HTML Source.
Below the Document Type Name, add item, select from list, Icon File Name, and in value column type or paste in, BracketsDoc.icns.
Do this for all of the types that you wish.
Given the simplicity, I am surprised this is an issue. But then I am surprised how much it bugs the hell out of me to see the generic doc icon.

@studiomantis
Copy link

@MLCozad thanks for your contribution. Could you please post a screenshot? Im kinda new in web development and i have a difficult to execute what you said.

This is where i got stucked:
"Below the Document Type Name, add item, select from list, Icon File Name, and in value column type or paste in, BracketsDoc.icns."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

11 participants