Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

appshell.fs.showOpenDialog: Windows wchar_t buffer is too small #5270

Closed
redmunds opened this issue Sep 19, 2013 · 5 comments · Fixed by adobe/brackets-shell#397
Closed

appshell.fs.showOpenDialog: Windows wchar_t buffer is too small #5270

redmunds opened this issue Sep 19, 2013 · 5 comments · Fixed by adobe/brackets-shell#397
Assignees
Milestone

Comments

@redmunds
Copy link
Contributor

Moved from https://github.com/adobe/brackets-shell/issues/330 by @bgagnon

The wchart_t buffer (szFile) is of size MAX_PATH (260 on my platform). This is not sufficient to handle medium size collections of UNC paths on Windows, particularly on network drives.

When "allowMultipleSelection" is true, the buffer should be large enough to accommodate collections of paths. In my particular installation, I needed to support several thousand file selections to deal with image sequences.

@ghost ghost assigned JeffryBooher Sep 23, 2013
@gruehle
Copy link
Member

gruehle commented Sep 23, 2013

Medium priority to @JeffryBooher. We should definitely use a larger buffer size here...

@njx
Copy link

njx commented Nov 16, 2013

Nominating for sprint 35.

@redmunds
Copy link
Contributor Author

redmunds commented Dec 6, 2013

@JeffryBooher I merged adobe/brackets-shell#397 to get longer file paths, but I don't see how it fixes the request for "several thousand file selections", so I'm leaving this bug open.

@redmunds redmunds reopened this Dec 6, 2013
@redmunds
Copy link
Contributor Author

redmunds commented Dec 6, 2013

@bgagnon We're not really sure what you're asking for here. Can you provide a use case where you would need a collection of "several thousand file selections"? Thanks.

@JeffryBooher JeffryBooher added this to the Brackets 1.0 milestone Mar 18, 2014
@njx
Copy link

njx commented Apr 14, 2014

Closing since we haven't heard back about the use case that would require an excessively long buffer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants