font-family is incorrect when lang="zh-Hant" #3834
Assignees
Labels
Comments
|
TODO: check that this font is in the typekit |
matthewdeutsch
moved this from ✏️ To Groom
to 📋 Waiting for Sprint
in RSP Component Milestones
5 tasks
ktabors
moved this from 📋 Waiting for Sprint
to 🏗 In Progress
in RSP Component Milestones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
When <html lang="zh-Hant" ... /> the font-family is simplified Chinese not traditional Chinese as expected.
🤔 Expected Behavior
zh-Hant = traditional Chinese
😯 Current Behavior
Spectrum-CSS and RS's copy of Spectrum-CSS do not have an entry for
lang:(zh-Hant)so the font family defaults to the one forzhwhich is the same aszh-Hanswhich is the wrong font-family.Currently
font-family: 'adobe-clean-han-simplified-c', 'SimSun', 'Heiti SC Light', 'sans-serif';See https://github.com/adobe/react-spectrum/blob/main/packages/%40adobe/spectrum-css-temp/components/commons/fonts.css#L56
and
https://github.com/adobe/spectrum-css/blob/43a159f9fcc1a5114ea59fd61f5e63ecf6e7b1fa/components/typography/font.css#L29
Note
zh-Hantmaps to RS'sI18nProviderlocale="zh-TW".💁 Possible Solution
Add entry in the above files for
zh-Hant.🔦 Context
Our loc QE spotted this issue and filed a bug against our product. They expect
font-family: 'adobe-clean-han-traditional', 'MingLiu', 'Heiti TC Light','sans-serif';💻 Code Sample
🌍 Your Environment
🧢 Your Company/Team
Adobe Admin Console
🕷 Tracking Issue (optional)
The text was updated successfully, but these errors were encountered: