fix(actionbutton, closebutton, picker): remove !important declarations

This removes the `!important` declarations that were placed upon `box-shadow`s to forcefully remove focus rings. Using `!important` was causing problems for folks who were trying to customize the focus rings, especially in a Windows High Contrast Mode context.
adobe · Jun 29, 2022 · a26c212 · a26c212
1 parent 68b7516
commit a26c212
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/components/actionbutton/index.css b/components/actionbutton/index.css
@@ -232,7 +232,8 @@ a.spectrum-ActionButton {
   }
 
   &:focus-ring {
-    box-shadow: none !important;
+    /* kill the default ring */
+    box-shadow: none;
 
     &:after {
       box-shadow: 0 0 0 var(--mod-actionbutton-focus-ring-thickness, var(--spectrum-actionbutton-focus-ring-thickness)) var(--highcontrast-actionbutton-focus-ring-color, var(--mod-actionbutton-focus-ring-color, var(--spectrum-actionbutton-focus-ring-color)));

diff --git a/components/closebutton/index.css b/components/closebutton/index.css
@@ -51,7 +51,7 @@ a.spectrum-CloseButton {
 
   &:focus-ring {
     /* kill the default ring */
-    box-shadow: none !important;
+    box-shadow: none;
 
     &:after {
       box-shadow: 0 0 0 var(--spectrum-closebutton-focus-ring-size) var(--spectrum-closebutton-focus-ring-color);

diff --git a/components/picker/index.css b/components/picker/index.css
@@ -137,7 +137,7 @@ governing permissions and limitations under the License.
 
   &:focus-ring {
     /* kill the default ring */
-    box-shadow: none !important;
+    box-shadow: none;
 
     &:after {
       box-shadow: 0 0 0 var(--spectrum-picker-focus-ring-size) var(--spectrum-picker-focus-ring-color);