Skip to content

Commit

Permalink
feat: renamed dropdown to picker (#540)
Browse files Browse the repository at this point in the history
  • Loading branch information
GarthDB authored Jul 28, 2020
1 parent 33d6638 commit d1081f0
Show file tree
Hide file tree
Showing 19 changed files with 588 additions and 474 deletions.
139 changes: 0 additions & 139 deletions components/dropdown/index.css

This file was deleted.

80 changes: 0 additions & 80 deletions components/dropdown/skin.css

This file was deleted.

24 changes: 12 additions & 12 deletions components/fieldlabel/metadata/form.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel spectrum-FieldLabel--left" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down Expand Up @@ -122,10 +122,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel spectrum-FieldLabel--right" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down Expand Up @@ -219,10 +219,10 @@ examples:
<div class="spectrum-Form-item">
<label class="spectrum-Form-itemLabel" for="spectrum-textinput-instance">Country</label>
<div class="spectrum-Form-itemField">
<div class="spectrum-Dropdown" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Dropdown-trigger" aria-haspopup="true">
<span class="spectrum-Dropdown-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Dropdown-icon" focusable="false" aria-hidden="true">
<div class="spectrum-Picker" style="width: 195px;">
<button class="spectrum-FieldButton spectrum-Picker-trigger" aria-haspopup="true">
<span class="spectrum-Picker-label is-placeholder">Select a Country</span>
<svg class="spectrum-Icon spectrum-UIIcon-ChevronDownMedium spectrum-Picker-icon" focusable="false" aria-hidden="true">
<use xlink:href="#spectrum-css-icon-ChevronDownMedium" />
</svg>
</button>
Expand Down
4 changes: 2 additions & 2 deletions components/fieldlabel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"devDependencies": {
"@spectrum-css/checkbox": "^3.0.0-beta.3",
"@spectrum-css/component-builder": "^1.2.0",
"@spectrum-css/dropdown": "^3.0.0-beta.3",
"@spectrum-css/picker": "^1.0.0",
"@spectrum-css/icon": "^2.1.1",
"@spectrum-css/radio": "^3.0.0-beta.2",
"@spectrum-css/stepper": "^3.0.0-beta.4",
Expand All @@ -34,4 +34,4 @@
"access": "public"
},
"homepage": "https://opensource.adobe.com/spectrum-css/"
}
}
File renamed without changes.
File renamed without changes.
5 changes: 3 additions & 2 deletions components/dropdown/README.md → components/picker/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# @spectrum-css/dropdown
> The Spectrum CSS dropdown component
# @spectrum-css/picker

> The Spectrum CSS picker component
This package is part of the [Spectrum CSS project](https://github.com/adobe/spectrum-css).

Expand Down
File renamed without changes
File renamed without changes.
Loading

4 comments on commit d1081f0

@lazd
Copy link
Member

@lazd lazd commented on d1081f0 Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit was missing BREAKING CHANGE @GarthDB

@GarthDB
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@lazd
Copy link
Member

@lazd lazd commented on d1081f0 Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GarthDB that said, on second thought, it's really just a new component, and the old one won't be released again soo.... It's fine!

@GarthDB
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I definitely did that on purpose. 100% It definitely wasn't a mistake gone right.

Please sign in to comment.