Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Typography T-shirt sizing syntax #1031

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Update Typography T-shirt sizing syntax #1031

merged 5 commits into from
Oct 15, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Oct 1, 2020

Description

Change the typography t-shirt size classes from .spectrum-Heading--XXXL to .spectrum-Heading--sizeXXXL

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB
Copy link
Member Author

GarthDB commented Oct 1, 2020

I need to update migration guides; I just want to check VRT.

@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB GarthDB requested a review from lazd October 15, 2020 18:07
lazd
lazd requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of little errors, once those are fixed I'll check it out locally and see if it's good to go.

components/rating/metadata/rating.yml Outdated Show resolved Hide resolved
tools/component-builder/css/processors.js Outdated Show resolved Hide resolved
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@GarthDB GarthDB requested a review from lazd October 15, 2020 18:15
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

lazd
lazd requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking if we get the migration guide updated to point at the new-new classes, and if VRT does not fail anywhere, this is good.

components/typography/metadata/typography.yml Show resolved Hide resolved
@GarthDB GarthDB requested a review from lazd October 15, 2020 18:54
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@lazd lazd merged commit 1a604c4 into main Oct 15, 2020
@lazd lazd mentioned this pull request Oct 15, 2020
Closed
3 tasks
@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB GarthDB deleted the issue-972 branch October 15, 2020 20:08
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazd lazd lazd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarthDB @adobe-spectrum-bot @lazd