fix: #1045 chevron icon in picker got squeezed

[jianliao]

Description

Since the new chevron ui icon increased its size to 10x10. It got squeezed in some scenarios.

Fixed #1045

How and where has this been tested?

• How this was tested:
• Browser(s) and OS(s) this was tested with:

Screenshots

Before:

After:

To-do list

• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.

• This pull request is ready to merge.

[adobe-spectrum-bot]

Spectrum CSS documentation build successfully! 🎉

View the documentation

[adobe-spectrum-bot]

VRT successfully! 🎊

View the VRT result

[lazd]

Interesting, so it has 2px of extra whitespace or something?

What about the fact that the class and the ID don't match?

          <svg class="spectrum-Icon spectrum-UIIcon-ChevronDown100 spectrum-Picker-icon" focusable="false" aria-hidden="true">
            <use xlink:href="#spectrum-css-icon-Chevron100" />
          </svg>

We have ChevronDown100 and Chevron100, what's up with that?

[jianliao]

If I understand correctly, we have icon css class spectrum-UIIcon-ChevronDown100. But we don't have an SVG icon id named spectrum-UIIcon-ChevronDown100.

[jianliao]

The chevron icon size changed from 10x6 to 10x10.

[lazd]

@jianliao then let's rename the class to match, classes and icon names should be identical, I don't know if they've ever been different before.