feat: moving generated code away from static vars #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazd
reviewed
Jan 4, 2022
lazd
reviewed
Jan 4, 2022
lazd
requested changes
Jan 4, 2022
There was a problem hiding this comment.
One quick thing: it's missing the purple accent color. Suggest referencing the following aliases to bring it back:
var(--spectrum-semantic-cta-background-color-default)
var(--spectrum-semantic-cta-background-color-down)
var(--spectrum-semantic-cta-background-color-hover)
var(--spectrum-semantic-cta-background-color-key-focus)
GarthDB
force-pushed
the
button-api-aliases
branch
from
cf262e6 to
9a5bfe4
Compare
lazd
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed static aliases in the generated button CSS.
How and where has this been tested?
Screenshots
To-do list