refactor(picker)!: use spectrum tokens #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosevu
changed the title
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
3 times, most recently
from
509b05c to
4ab4402
Compare
|
🚀 Deployed on https://pr-1528--spectrum-css.netlify.app |
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
80f89a0 to
7fa286b
Compare
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
d878607 to
0ed3d64
Compare
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
0ed3d64 to
b46e9b7
Compare
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
d2e7164 to
1b726e0
Compare
yosevu
commented
Oct 17, 2022
| @@ -45,6 +45,7 @@ examples: | |||
| name: Standard | |||
| markup: | | |||
| <h4>Closed</h4> | |||
| <div class="spectrum-FieldLabel spectrum-FieldLabel--sizeM">Country</div> | |||
There was a problem hiding this comment.
The design examples all use Field Labels, but I didn't think I should use a label with a button. What element should this be?
yosevu
commented
Oct 17, 2022
components/picker/index.css
Outdated
| border-width: var(--spectrum-picker-texticon-disabled-border-size); | ||
| cursor: default; | ||
| /* Placeholder tokens */ | ||
| .spectrum--medium { |
There was a problem hiding this comment.
These were the existing offsets for aligning popover with picker.
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
1b726e0 to
c758e46
Compare
lunarfusion
suggested changes
Oct 26, 2022
yosevu
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
36b6c45 to
78d6230
Compare
Still need to update Invalid red box shadows Still need to add focus-indicator gap
- Rename border-size to border-width - Remove Help text from other example - Remove focus state box-shadow transition - Fix quiet indicator gap
The design for this variant will be updated.
- Add Popover offset to align with Picker
- Hide focus indicator when menu is-open
pfulton
force-pushed
the
yosevu/css-156-migrate-picker-to-core-tokens
branch
from
9672a47 to
e826552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Picker to use core tokens and update WHCM.
How and where has this been tested?
Screenshots
To-do list