chore(tokens): use latest dependency & fix build error #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
2 times, most recently
from
d8c673a to
75f5fef
Compare
|
🚀 Deployed on https://pr-1591--spectrum-css.netlify.app |
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
from
75f5fef to
4050556
Compare
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
from
adf364e to
a2b2c56
Compare
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
from
764f035 to
279a337
Compare
castastrophe
approved these changes
Jan 31, 2023
lunarfusion
suggested changes
Jan 31, 2023
components/breadcrumb/index.css
Outdated
| @@ -18,35 +18,35 @@ governing permissions and limitations under the License. | |||
| --spectrum-breadcrumbs-block-size-multiline: var(--spectrum-breadcrumbs-height-multiline); | |||
|
|
|||
| /* text regular */ | |||
| --spectrum-breadcrumbs-line-height: var(--spectrum-line-height-small); | |||
| --spectrum-breadcrumbs-line-height: var(--spectrum-line-height-100); | |||
| --spectrum-breadcrumbs-font-size: var(--spectrum-font-size-200); | |||
| --spectrum-breadcrumbs-font-family: var(--spectrum-font-family-base); /* placeholder for --spectrum-font-family-default */ | |||
There was a problem hiding this comment.
Since we are using the custom vars token name of --spectrum-font-family-base, I think this placeholder note (referencing the original token name provided in the XD) can be removed:
/* placeholder for --spectrum-font-family-default */
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
from
227bbee to
59b7c26
Compare
lunarfusion
approved these changes
Feb 1, 2023
pfulton
force-pushed
the
castastrophe/chore-bump-tokens-beta64-CSS-379
branch
from
59b7c26 to
2ce0862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@spectrum-css/tokenspackage to use the latest release of@adobe/spectrum-tokensundefinedcustom property errors as a result of renamed tokens introduced in the previous bullet pointtokens/custom-spectrum/custom-vars.cssand uses custom properties driven by@adobe/spectrum-tokensinstead.undefinedcustom property errors as a result of the previous bullet point.How and where has this been tested?
Screenshots
To-do list