Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textfield,picker): restore missing vars #1607

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix(textfield,picker): restore missing vars #1607

merged 2 commits into from
Feb 1, 2023

Conversation

pfulton
Copy link
Collaborator

@pfulton pfulton commented Jan 31, 2023

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • This pull request is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023 •
edited
Loading

🚀 Deployed on https://pr-1607--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 31, 2023 21:45 Inactive
@pfulton pfulton requested a review from Westbrook January 31, 2023 22:50
@pfulton
Copy link
Collaborator Author

pfulton commented Jan 31, 2023

@Westbrook two betas for you to try:

@pfulton pfulton changed the title fix(textfield): restore missing var fix(textfield): restore missing var (DO NOT MERGE) Jan 31, 2023
@github-actions github-actions bot temporarily deployed to pull request January 31, 2023 22:54 Inactive
Westbrook
Westbrook approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These appear to have the values that were missing! I'm good for a full release if you are 🤞🏼

https://unpkg.com/browse/@spectrum-css/[email protected]/dist/index-vars.css#L43
https://unpkg.com/browse/@spectrum-css/[email protected]/dist/index-vars.css#L160

@pfulton pfulton changed the title fix(textfield): restore missing var (DO NOT MERGE) fix(textfield): restore missing vars Feb 1, 2023
@pfulton pfulton changed the title fix(textfield): restore missing vars fix(textfield,picker): restore missing vars Feb 1, 2023
@pfulton pfulton force-pushed the pfulton/fix--missing-vars branch from 8ce3074 to 246bee5 Compare February 1, 2023 20:14
@github-actions github-actions bot temporarily deployed to pull request February 1, 2023 20:21 Inactive
@pfulton pfulton merged commit 45f36f6 into main Feb 1, 2023
@pfulton pfulton deleted the pfulton/fix--missing-vars branch February 1, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfulton @Westbrook