-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(picker): resolve font-style, focus-ring, border issues #1618
Conversation
🚀 Deployed on https://pr-1618--spectrum-css.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old focus indicator used box-shadow which can now be removed (lines 190 220, 496, 509, 518, 521).
50a3c40
to
ba775aa
Compare
401d213
to
561b087
Compare
Is this rectangle intended?
This also show how the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to approve this is you'd like, but wanted to get some nits and conceptual questions in front of you before I did.
561b087
to
0ce1981
Compare
0ce1981
to
b87b039
Compare
b87b039
to
7363849
Compare
* fix(picker): correct focus-ring issues * fix(picker): prefer normal instead of italic for placeholder font-style * fix(picker): resolve focus indicator issues * fix(picker): resolve missing quiet focus indicator
Description
This addresses several issues with the Picker:
font-style: normal
instead ofitalic
for the placeholderfocus-ring
wasn't aligned properly in Expressborder-width
when Express should not have a border.How and where has this been tested?
Screenshots
To-do list