Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): update border colors #1763

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix(picker): update border colors #1763

merged 1 commit into from
Apr 14, 2023

Conversation

mlogsdon18
Copy link
Contributor

Description

This PR updates the border color tokens for Picker based on updated designs for Spectrum to meet accessibility guidelines. There were no changes to Express styling.

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • This pull request is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023 •
edited
Loading

🚀 Deployed on https://pr-1763--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 10, 2023 19:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 10, 2023 19:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 11, 2023 13:54 Inactive
Westbrook
Westbrook approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot temporarily deployed to pull request April 11, 2023 19:55 Inactive
castastrophe
castastrophe approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great from a code perspective, just need confirmation of design approval?

@github-actions github-actions bot temporarily deployed to pull request April 12, 2023 19:08 Inactive
@pfulton pfulton added run_vrt For use on PRs looking to kick off VRT and removed run_vrt For use on PRs looking to kick off VRT labels Apr 13, 2023
@pfulton pfulton force-pushed the fix--picker-border branch from a9ae43b to e519ac0 Compare April 13, 2023 14:38
@github-actions github-actions bot temporarily deployed to pull request April 13, 2023 14:45 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Apr 13, 2023
@pfulton pfulton force-pushed the fix--picker-border branch from e519ac0 to 4c67770 Compare April 14, 2023 17:37
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Apr 14, 2023
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 17:51 Inactive
@pfulton pfulton self-requested a review April 14, 2023 18:04
@pfulton pfulton merged commit 8932811 into main Apr 14, 2023
@pfulton pfulton deleted the fix--picker-border branch April 14, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfulton pfulton pfulton approved these changes

@Westbrook Westbrook Westbrook approved these changes

@castastrophe castastrophe castastrophe approved these changes

Assignees

@pfulton pfulton

@Westbrook Westbrook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlogsdon18 @pfulton @Westbrook @castastrophe