Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): update spacing tokens and storybook #1804

Merged
merged 13 commits into from
May 3, 2023
Merged

fix(picker): update spacing tokens and storybook #1804

merged 13 commits into from
May 3, 2023

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Apr 24, 2023 •
edited
Loading

Description

This updates the Spacing (top/bottom and end edge to disclosure icon) tokens for the Picker component.

There were also some things that were not in Storybook or were not working in Storybook that I went ahead and fixed in this PR as well as styles that were not being used how the Figma was specifying

  • Added a separate Quiet story
  • Added a separate Loading story and the functionality required
  • Added a FieldLabel
  • Updated icons based on size for PickerButton
  • Fixed min-inline-size to use the multiplier correctly

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • This pull request is ready to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023 •
edited
Loading

🚀 Deployed on https://pr-1804--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 24, 2023 19:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 13:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 25, 2023 18:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 13:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 15:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 27, 2023 14:29 Inactive
@mlogsdon18 mlogsdon18 marked this pull request as ready for review April 27, 2023 14:46
@mlogsdon18 mlogsdon18 force-pushed the fix--picker-spacing branch from 0e6ca73 to 5a67042 Compare April 27, 2023 14:47
@github-actions github-actions bot temporarily deployed to pull request April 27, 2023 14:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 28, 2023 16:54 Inactive
@mlogsdon18 mlogsdon18 force-pushed the fix--picker-spacing branch from 1e43c5f to b08cb99 Compare May 1, 2023 19:24
@github-actions github-actions bot temporarily deployed to pull request May 1, 2023 19:32 Inactive
@mlogsdon18 mlogsdon18 force-pushed the fix--picker-spacing branch from b08cb99 to 3ec1e22 Compare May 2, 2023 19:21
@github-actions github-actions bot temporarily deployed to pull request May 2, 2023 19:29 Inactive
mlogsdon18 added 12 commits May 3, 2023 15:14
@mlogsdon18 @pfulton
chore(picker,pickerbutton): update stories
0a4d39e 
update stories to include label
@mlogsdon18 @pfulton
chore(picker,pickerbutton): add loading state to stories
a8dd78f
@mlogsdon18 @pfulton
chore(picker): update icon size in stories
453f6af
@mlogsdon18 @pfulton
chore(picker): fixing label padding for story
0bb922c
@mlogsdon18 @pfulton
style(picker): update spacing tokens
26ac615
@mlogsdon18 @pfulton
feat(picker): update spacing tokens
bd8800d
@mlogsdon18 @pfulton
chore(picker): update storybook to match docs
2213e9e
@mlogsdon18 @pfulton
fix(pickerbutton): undo changes to pickerbutton
b00abf0
@mlogsdon18 @pfulton
chore(picker): get defaults set for storybook
d604d03
@mlogsdon18 @pfulton
chore(picker): updating stories to include express specific styling
9319132 
- adding express and spectrum specific styling to storybook
- fixing loading spacing
@mlogsdon18 @pfulton
chore(picker): update storybook
a76e62c 
- add invalid story
- add click functionality
@mlogsdon18 @pfulton
chore(picker): add focused story and fix icon focus color
14a6bb5
@pfulton pfulton force-pushed the fix--picker-spacing branch from 3ec1e22 to 14a6bb5 Compare May 3, 2023 19:14
@github-actions github-actions bot temporarily deployed to pull request May 3, 2023 19:20 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label May 3, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label May 3, 2023
@pfulton pfulton merged commit 1097b23 into main May 3, 2023
@pfulton pfulton deleted the fix--picker-spacing branch May 3, 2023 20:46
@github-actions github-actions bot temporarily deployed to pull request May 3, 2023 20:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlogsdon18 @castastrophe @pfulton