style(picker)!: add missing tokens #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2063--spectrum-css.netlify.app |
pfulton
force-pushed
the
css-483-picker-layout-tokens
branch
from
617636f to
2550569
Compare
|
@Westbrook - just a note here that this will remove the medium size class ( @mlogsdon18 noting that we'll make this a breaking change when merging in! |
mlogsdon18
force-pushed
the
css-483-picker-layout-tokens
branch
from
57e5b81 to
7885f5b
Compare
mlogsdon18
changed the title
Westbrook
reviewed
Aug 4, 2023
Comment on lines
-15
to
-22
| /* Placeholder tokens to align Popover with Picker */ | ||
| .spectrum--medium { | ||
| --spectrum-picker-popover-quiet-offset-x: 12px; | ||
| } | ||
|
|
||
| .spectrum--large { | ||
| --spectrum-picker-popover-quiet-offset-x: 14px; | ||
| } |
Added inline-size for new field-width token Removed medium size vars as they were set by default Added spacing tokens for the label, validation icon, and progress circle Removed margin-inline for quiet picker popovers
mlogsdon18
force-pushed
the
css-483-picker-layout-tokens
branch
from
7885f5b to
fa9611e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
field-widthtokenHow and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Storybook Test:
- [ ] Verify that all stories load correctly
Docs Test:
- [ ] Docs site displays examples correctly
- [ ] Inspect and verify that the new
field-widthtoken has been added and is being used for a default width- [ ] Inspect and verify that the
field-top-to-disclosure-icon-[size],field-end-edge-to-disclosure-icon-[size]andpicker-end-edge-to-disclosure-icon-quiettokens are all in use for the Chevron padding.Regression testing
Validate:
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨