Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker): add separate mod for label font-weight #2079

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

mlogsdon18
Copy link
Contributor

@mlogsdon18 mlogsdon18 commented Aug 9, 2023

Description

CSS-573

This adds a font-weight property with a mod to the .spectrum-Picker-label class. There is a font-weight mod that already existed for the placeholder (if the label also had the .is-placeholder class) so I also updated that mod to be --mod-picker-placeholder-font-weight so that they stayed separate.

In testing this I also realized that the Picker storybook did not implement customStyles so I added that ability too. I also renamed the internal component of PickerButton to Picker to avoid confusion with the actual Picker Button component.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

  1. Open the docs for the Picker component:
    - [ ] Inspect the page and add a --mod-picker-font-weight: 800 to the first example.
    - [ ] Verify that the placeholder font-weight does not change
    - [ ] Add the same mod --mod-picker-font-weight: 800 to the Open example
    - [ ] Verify that the font weight for the selected value inside the Picker changes

Screenshot 2023-08-09 at 3 26 14 PM

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🚀 Deployed on https://pr-2079--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 19:35 Inactive
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pfulton pfulton merged commit 1f8e486 into main Aug 10, 2023
@pfulton pfulton deleted the fix--picker-bold branch August 10, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants