fix(picker): add separate mod for label font-weight #2079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSS-573
This adds a
font-weight
property with a mod to the.spectrum-Picker-label
class. There is a font-weight mod that already existed for the placeholder (if the label also had the.is-placeholder
class) so I also updated that mod to be--mod-picker-placeholder-font-weight
so that they stayed separate.In testing this I also realized that the Picker storybook did not implement customStyles so I added that ability too. I also renamed the internal component of PickerButton to Picker to avoid confusion with the actual Picker Button component.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
- [ ] Inspect the page and add a
--mod-picker-font-weight: 800
to the first example.- [ ] Verify that the placeholder font-weight does not change
- [ ] Add the same mod
--mod-picker-font-weight: 800
to the Open example- [ ] Verify that the font weight for the selected value inside the Picker changes
Regression testing
Validate:
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨