Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing semicolons in custom vars #2163

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jawinn
Copy link
Collaborator

@jawinn jawinn commented Sep 11, 2023

Description

  • Add missing semicolons to two custom properties added to custom-large-vars and custom-medium-vars
  • Cleans up formatting to remove/add some extra spaces on some other declarations with the custom CSS files.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

- Add missing semicolons to two custom properties added to
  custom-large-vars and custom-medium-vars
- Cleans up formatting to remove/add some extra spaces on some other
  declarations with the custom CSS files.
@github-actions
Copy link
Contributor

🚀 Deployed on https://pr-2163--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 11, 2023 21:44 Inactive
@jawinn jawinn added the run_vrt For use on PRs looking to kick off VRT label Sep 11, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Sep 11, 2023
@pfulton pfulton merged commit 814c49e into main Sep 12, 2023
@pfulton pfulton deleted the jawinn/fix-tokens-custom-semicolons branch September 12, 2023 13:36
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
@github-actions github-actions bot mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants