Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: deprecate vars and expressvars from monorepo structure #2244

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat!: deprecate vars and expressvars from monorepo structure #2244

merged 1 commit into from
Nov 13, 2023

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Oct 31, 2023 •
edited
Loading

Description

As the removal of vars and expressvars from the monorepo is a major breaking change, I'm pulling this work out into a small PR. Updates are made to pull the content from node_modules rather than locally so the build continues to work.

This does not prevent downstream users from consuming the packages at their currently published tag but as no future updates are planned they no longer need to exist in the repository.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch 2 times, most recently from 6df5b6a to e09b05a Compare October 31, 2023 17:32
@castastrophe castastrophe marked this pull request as ready for review October 31, 2023 17:34
@castastrophe castastrophe requested a review from pfulton October 31, 2023 17:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

🚀 Deployed on https://pr-2244--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 17:39 Inactive
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@castastrophe castastrophe marked this pull request as draft October 31, 2023 17:40
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from e09b05a to cbfe079 Compare October 31, 2023 17:52
@castastrophe castastrophe marked this pull request as ready for review October 31, 2023 17:54
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 17:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 19:20 Inactive
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Oct 31, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from 4ce0cc6 to f69bf13 Compare November 1, 2023 12:35
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 12:41 Inactive
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from f69bf13 to c388054 Compare November 1, 2023 12:52
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from c388054 to 75c20bc Compare November 1, 2023 12:55
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 12:59 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch 2 times, most recently from d554184 to e2fe78c Compare November 1, 2023 15:33
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@github-actions github-actions bot temporarily deployed to pull request November 1, 2023 15:38 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from e2fe78c to fdd47f4 Compare November 1, 2023 15:40
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Nov 1, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from fdd47f4 to 19e64c2 Compare November 1, 2023 15:43
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch 3 times, most recently from 9dbd444 to 41aa824 Compare November 10, 2023 18:47
@castastrophe castastrophe marked this pull request as ready for review November 10, 2023 18:49
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from c6e0345 to 9848be0 Compare November 10, 2023 19:18
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from 9848be0 to a43e0f3 Compare November 10, 2023 19:26
@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Nov 10, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from a43e0f3 to ef7d637 Compare November 10, 2023 20:01
@castastrophe castastrophe reopened this Nov 10, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch 5 times, most recently from c1ffc8a to 2f354e4 Compare November 10, 2023 20:54
@castastrophe castastrophe removed run_vrt For use on PRs looking to kick off VRT ready-for-review labels Nov 10, 2023
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from 2f354e4 to 82b4c3a Compare November 10, 2023 21:00
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch 2 times, most recently from 6e9a031 to 641fe9e Compare November 13, 2023 19:46
@castastrophe
feat(vars,expressvars)!: deprecate packages
ce79764 
BREAKING CHANGE: as no additional changes have been or are planned to be made to
these legacy token packages, these assets no longer need to exist in the monorepo
structure for Spectrum CSS.
@castastrophe castastrophe force-pushed the feat-deprecating-old-token-packages branch from 641fe9e to ce79764 Compare November 13, 2023 19:49
@castastrophe castastrophe merged commit 5eb391c into main Nov 13, 2023
@castastrophe castastrophe deleted the feat-deprecating-old-token-packages branch November 13, 2023 20:50
This was referenced Apr 26, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfulton pfulton pfulton approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@castastrophe @pfulton