fix(coachmark): update font family tokens #2478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tokens specified for font family in CoachMark all use
--spectrum-sans-serif-font-family
orAdobe Clean
, we need them to instead use our custom token--spectrum-sans-serif-font
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Each instance should be referencing custom token
--spectrum-sans-serif-font:var(--spectrum-sans-font-family-stack);
and in turn
--spectrum-sans-font-family-stack:adobe-clean, var(--spectrum-sans-serif-font-family), 'Source Sans Pro', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Ubuntu, 'Trebuchet MS', 'Lucida Grande', sans-serif;
and display a sans-serif font.
On Chrome
--spectrum-CoachMark-title
font is correct--spectrum-CoachMark-content
font is correct--spectrum-CoachMark-step
font is correctOn Safari
--spectrum-CoachMark-title
font is correct--spectrum-CoachMark-content
font is correct--spectrum-CoachMark-step
font is correctOn Firefox
--spectrum-CoachMark-title
font is correct--spectrum-CoachMark-content
font is correct--spectrum-CoachMark-step
font is correctRegression testing
Validate:
Screenshots
To-do list