Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coachmark): update font family tokens #2478

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Jan 31, 2024

Description

The tokens specified for font family in CoachMark all use --spectrum-sans-serif-font-family or Adobe Clean, we need them to instead use our custom token --spectrum-sans-serif-font

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Each instance should be referencing custom token
--spectrum-sans-serif-font:var(--spectrum-sans-font-family-stack);
and in turn
--spectrum-sans-font-family-stack:adobe-clean, var(--spectrum-sans-serif-font-family), 'Source Sans Pro', -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Ubuntu, 'Trebuchet MS', 'Lucida Grande', sans-serif;
and display a sans-serif font.

On Chrome

  • CoachMark docs site and storybook --spectrum-CoachMark-title font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-content font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-step font is correct

On Safari

  • CoachMark docs site and storybook --spectrum-CoachMark-title font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-content font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-step font is correct

On Firefox

  • CoachMark docs site and storybook --spectrum-CoachMark-title font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-content font is correct
  • CoachMark docs site and storybook --spectrum-CoachMark-step font is correct

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz marked this pull request as ready for review January 31, 2024 22:35
Copy link
Contributor

github-actions bot commented Jan 31, 2024

File metrics

Summary

Total size: 3.94 MB*
Total change (Δ): ⬇ 0.14 KB (-0.00%)
Table reports on changes to a package's main file. Other changes can be found in the collapsed "Details" below.

Package Size Δ
coachmark 7.67 KB ⬇ 0.04 KB
Details

coachmark

File Head Base Δ
index-base.css 7.67 KB 7.71 KB ⬇ 0.04 KB (-0.57%)
index-vars.css 7.67 KB 7.71 KB ⬇ 0.04 KB (-0.57%)
index.css 7.67 KB 7.71 KB ⬇ 0.04 KB (-0.57%)
mods.json 1.20 KB 1.20 KB -
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

🚀 Deployed on https://pr-2478--spectrum-css.netlify.app

@jenndiaz jenndiaz added run_vrt For use on PRs looking to kick off VRT ready-for-review labels Jan 31, 2024
@jenndiaz jenndiaz requested review from pfulton, jawinn and mdt2 January 31, 2024 22:59
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this! It looks good in the different browsers and the VRT differences look expected to me 👍

@jenndiaz jenndiaz removed the run_vrt For use on PRs looking to kick off VRT label Feb 2, 2024
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pfulton pfulton force-pushed the jenndiaz/coachmark-font-family-fix branch from c8509c9 to 2eea346 Compare February 6, 2024 19:59
@pfulton pfulton merged commit 0a3a946 into main Feb 6, 2024
10 checks passed
@pfulton pfulton deleted the jenndiaz/coachmark-font-family-fix branch February 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants