Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logicbutton,picker): add missing commons devDep #2631

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Apr 1, 2024

Description

Add missing devDependency @spectrum-css/commons to logicbutton and picker.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Should see no changes or regressions.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

Copy link
Contributor

github-actions bot commented Apr 1, 2024

🚀 Deployed on https://pr-2631--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Apr 1, 2024

File metrics

Summary

Total size: 4.51 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe self-assigned this Apr 1, 2024
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review labels Apr 1, 2024
@castastrophe castastrophe marked this pull request as ready for review April 1, 2024 15:07
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👏

@jawinn jawinn self-requested a review April 1, 2024 15:19
@castastrophe castastrophe force-pushed the fix-add-missing-commons-dep branch from cda21f4 to 6a6254d Compare April 1, 2024 15:19
@castastrophe castastrophe enabled auto-merge (squash) April 1, 2024 15:19
Copy link
Collaborator

@jawinn jawinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@castastrophe castastrophe merged commit 49057ca into main Apr 1, 2024
16 of 22 checks passed
@castastrophe castastrophe deleted the fix-add-missing-commons-dep branch April 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants