-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to individually versioned packages with Lerna #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs page for giggles
… are viewed (this probably needs an onload for the link to prevent FOUC)
…, it seems, and require.resolve() can't find them)
support linking between bundle changelogs and component changelogs lots of pretty emojis
add ignore-optional to yarn config use yarn to install global gulp-cli package for ci
refactor subrunner to work on arbitrary collections of packages fix some cwd-induced bugs
only check if peerDependencies satisfy devDependencies, fail if they don't release all bundles with npm run release-bundles update docs
Conventional Commits & Changelogs
bernhard-adobe
approved these changes
Sep 19, 2019
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Description
Move to individually versioned packages with Lerna #179
Documentation
DOMContentLoaded
, we check for custom properties support withCSS.supports()
and swap out CSS files if its not supported. This means thatindex.vars
does still get requested by the browser, but is replaced beforeload
.gulp devHeavy
to build multistops for testing in IEChores
Bug fixes
a
tag is not centered #239adobe-clean-ux
as fallback font #189 (Font fallbacks #248)Testing
Currently in use in React Spectrum master: https://github.com/adobe/react-spectrum/
React Spectrum storybook with 2.14.0-alpha.16: http://lfbuild.corp.adobe.com:8080/job/adobe/job/react-spectrum/job/master/124/Report_20adobe_20public_2fstorybook/
Branch in Angular Spectrum: https://git.corp.adobe.com/AMO/ngx-spectrum-components/tree/verify_ivc_spectrum
A diff script is included that diffs the component build files against 2.13. To run it:
Basic Create React App POC testing implementation in React / JavaScript / HTML5:
https://git.corp.adobe.com/bschmidt/spectrum-css-individual-versioning-poc-SDS-1812
Ticket: SDS-1812
Types of changes