Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename dropdown to picker #540

Merged
merged 2 commits into from
Jul 28, 2020
Merged

refactor: rename dropdown to picker #540

merged 2 commits into from
Jul 28, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Feb 20, 2020 •
edited
Loading

Description

Renaming Dropdown to Picker following design API discussions.

How and where has this been tested?

Testing locally

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB GarthDB added the breaking change Results in a breaking API change label Feb 20, 2020
@GarthDB
Copy link
Member Author

GarthDB commented Feb 20, 2020

Related to #234

@lazd lazd changed the base branch from rtl to master March 9, 2020 16:16
@GarthDB GarthDB force-pushed the dropdown-picker-rename branch from 96d3479 to 4927023 Compare June 16, 2020 22:42
@GarthDB GarthDB requested a review from lazd June 16, 2020 22:43
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/d239812-result-2020-06-16_22-53-15/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/d239812-result-2020-06-16_22-53-15/dist/docs/

bernhard-adobe
bernhard-adobe approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent renaming and adding of options.

@bernhard-adobe
Copy link
Contributor

might need a re-base

bernhard-adobe
bernhard-adobe approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great re-naming. We did the same in SVG-Generator.

lazd
lazd requested changes Jul 8, 2020
View reviewed changes
components/picker/package.json Outdated
@@ -1,13 +1,13 @@
{
"name": "@spectrum-css/dropdown",
"name": "@spectrum-css/picker",
"version": "2.1.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think the version would start at 1.0.0 for new or renamed components.

@GarthDB GarthDB changed the base branch from master to main July 21, 2020 17:21
@GarthDB GarthDB merged commit d1081f0 into main Jul 28, 2020
@GarthDB GarthDB deleted the dropdown-picker-rename branch July 28, 2020 23:19
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@jianliao jianliao mentioned this pull request Jul 30, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazd lazd lazd requested changes

@bernhard-adobe bernhard-adobe bernhard-adobe approved these changes

Assignees
No one assigned
Labels
breaking change Results in a breaking API change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GarthDB @adobe-spectrum-bot @bernhard-adobe @lazd