Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Breaking Changes #649

Merged
merged 12 commits into from
Apr 29, 2020
Merged

Button Breaking Changes #649

merged 12 commits into from
Apr 29, 2020

Conversation

lazd
Copy link
Member

@lazd lazd commented Mar 17, 2020 •
edited
Loading

Description

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Figure out if Action Group Compact needs to apply to quiet Action Buttons at all
  • This pull request is ready to merge.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/981bb2e-result-2020-03-17_19-04-58/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/981bb2e-result-2020-03-17_19-04-58/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/41e94ea-result-2020-03-17_19-06-15/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/41e94ea-result-2020-03-17_19-06-15/dist/docs/

lazd added 8 commits April 23, 2020 13:25
@lazd
feat: remove Tool button
acf9e4d 
BREAKING CHANGE: Tool button has been removed
@lazd
fix: interaction on mobile, text select
c461dce
@lazd
feat: add Emphasized Action Button
7cb5bc4
@lazd
docs: add exampes for Quiet Emphasized Action Button
99e1362 
fix: correct Quiet Emphasized Action Button
@lazd
feat: button group
721af47 
BREAKING CHANGE: Button group no longer supports Action Button, just normal buttons
@lazd
docs: document icon-only Action Button usage, closes #519
ea34c9a
@lazd
fix: remove margin from adjacent buttons, closes #620
4cfd0ed 
BREAKING CHANGE: Margins have been removed from adjacent buttons. Use ButtonGroup instead.
@lazd
feat: implement Action Group, closes #606
ed3e112
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/f728733-result-2020-04-23_21-50-25/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/f728733-result-2020-04-23_21-50-25/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/8ecbe1c-result-2020-04-24_16-10-04/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/8ecbe1c-result-2020-04-24_16-10-04/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/b3548b5-result-2020-04-24_19-54-09/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/b3548b5-result-2020-04-24_19-54-09/dist/docs/

@lazd lazd marked this pull request as ready for review April 27, 2020 17:45
@lazd lazd changed the title WIP: Button Breaking Changes Button Breaking Changes Apr 27, 2020
@jianliao
Copy link
Contributor

jianliao commented Apr 28, 2020 •
edited
Loading

@lazd Updated the VRT scenarios config file to include the new component actiongroup.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/1395768-result-2020-04-28_18-23-50/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/1395768-result-2020-04-28_18-23-50/dist/docs/

@jianliao
Copy link
Contributor

jianliao commented Apr 28, 2020 •
edited
Loading

VRT now covered actiongroup.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/14893d0-result-2020-04-29_19-36-22/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/14893d0-result-2020-04-29_19-36-22/dist/docs/

@jianliao jianliao merged commit abf116b into master Apr 29, 2020
@lazd lazd mentioned this pull request Apr 29, 2020
Closed
@lazd lazd mentioned this pull request Apr 29, 2020
Closed
@lazd lazd mentioned this pull request May 11, 2020
Closed
@GarthDB GarthDB deleted the button-rsp-v3 branch September 21, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianliao jianliao jianliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lazd @adobe-spectrum-bot @jianliao