Plotting tweaks: bug fix for x label, and support night shading with missing data #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Use na.rm when determining axis limits for night shading to be compatible with plotting with some missing values
|
Thanks @dsheldon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1: fix a bug where the
xlabargument passed toplot.vpiis not used and the x label is hard coded to "time" whenplotis called.Change 2: ignore NAs when automatically determining the y axis limits for night shading. This allows the night shading to work properly if the plotted quantity has NAs, which can be useful if you want to filter some values from plotting.