Skip to content
This repository has been archived by the owner on Feb 27, 2022. It is now read-only.

feat(assert): assert cookie exists #28

Merged

Conversation

RomainLanz
Copy link
Member

@RomainLanz RomainLanz commented Sep 23, 2018

Hey! 👋

Proposed changes

This PR let us assert that a cookie or a plainCookie exists without knowing it's value.

This is useful in some case like verifying that the cookie of the session exists after logging in.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Sep 23, 2018

Coverage Status

Coverage increased (+0.2%) to 80.83% when pulling fb11f37 on RomainForks:feature/assert-cookie-exists into 413090f on adonisjs:develop.

@RomainLanz RomainLanz force-pushed the feature/assert-cookie-exists branch from 325acf9 to e324c96 Compare September 23, 2018 22:16
@RomainLanz RomainLanz force-pushed the feature/assert-cookie-exists branch from e324c96 to fb11f37 Compare September 23, 2018 22:17
@RomainLanz RomainLanz changed the title feat(assert): assert cookie name feat(assert): assert cookie exists Sep 23, 2018
@thetutlage thetutlage merged commit 0d99590 into adonisjs:develop Sep 24, 2018
thetutlage pushed a commit to adonisjs/legacy-docs that referenced this pull request Sep 24, 2018
@RomainLanz RomainLanz deleted the feature/assert-cookie-exists branch September 24, 2018 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants