belongsTo not properly emptying when set to null

[nickschot]

Version

1.5.0

Test Case

#314

Steps to reproduce

I first spotted this in a changeset powered ember-bootstrap form w/ a power-select for (re)setting a belongsTo relationship. Works fine on 1.3.0.

Expected Behavior

The relationship is emptied properly.

Actual Behavior

It is not emptied :(

[nickschot]

Found the piece of code that causes this:

https://github.com/poteto/ember-changeset/blob/7bda87b2ae8f07754f7d07a122fe2efc4800918f/addon/index.js#L767-L771

[nickschot]

@snewcomer is there a need to relay anyway if the new value is not an object (mainly null)?

[urbany]

Hi, I'm on 1.3.0 and want to update to 1.5.0, is it possible to make a release with this fix? Thanks in advance!

[nickschot]

@snewcomer this seems to have broken again for me on 1.6.0 even though the PR #318 is in that release.

[snewcomer]

What release did it last work in?

[nickschot]

1.3, it seems #318 also didn't fix this exact issue as the section of code that's triggered is above that (see a couple comments back). I think the problem is that it only checks if the original is an object and then returns the relay, while the true value is now null as it's an empty relationship.

[nickschot]

I have not checked its status in the 2.0 beta which I just noticed exists on a branch. Might be different there if its not using relay anymore.

[snewcomer]

I’m guessing this is fixed now as of 2.0z. I’ll close for now but feel free to reopen!