Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a value to null does not allow it to enter any value after that #654

Closed
rajeshbolisetty opened this issue Jul 25, 2022 · 3 comments · Fixed by #655
Closed

Setting a value to null does not allow it to enter any value after that #654

rajeshbolisetty opened this issue Jul 25, 2022 · 3 comments · Fixed by #655

Comments

@rajeshbolisetty
Copy link

Hi

Settings a the value to null, it not allowing me to enter any value after that and it is only happening in development build

and production build it is working as expected.

Any suggestions or help would be appreciated.

@snewcomer
Copy link
Collaborator

@rajeshbnv1994 I would need a reproducible example scenario to look into and fix this.

@SergeAstapov
Copy link
Contributor

@snewcomer I wonder if this line https://github.com/poteto/ember-changeset/blob/master/addon/utils/merge-deep.js#L8 needs to be

return !!value && typeof value === 'object' && value !== null;

due to typeof null === 'object' in JS

@rajeshbolisetty
Copy link
Author

@SergeAstapov you are correct, when i did debug that line is causing issue, but as @snewcomer requested , i might create a scenario and give more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants