Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Embroider optimized #316

Closed
Windvis opened this issue Oct 11, 2021 · 2 comments · Fixed by #432
Closed

Support Embroider optimized #316

Windvis opened this issue Oct 11, 2021 · 2 comments · Fixed by #432

Comments

@Windvis
Copy link
Contributor

Windvis commented Oct 11, 2021

I was researching if this addon was compatible with Embroider already so I stumbled on this discussion:
#279 (comment)

It seems some work needs to be done so I'm opening this issue to track that. 😄

@jherdman
Copy link
Contributor

It looks like the embroider-optimized strategy is failing now, and for good reason. Hopefully we can get there.

@Windvis
Copy link
Contributor Author

Windvis commented Nov 12, 2021

I think the easiest way to make this addon Embroider optimized compatible with the current code is to make users import the built-in adapters they want to use. Maybe we can document that in the readme for now and add it to the dummy app as well so CI no longer fails? This is essentially what #432 is doing but without moving the burden to the users.

It would give us more time to discuss which alternative configuration method we want to go for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants