Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical sort is broken on Firefox 134 #607

Open
cyril-sf opened this issue Jan 10, 2025 · 0 comments · May be fixed by #606
Open

Vertical sort is broken on Firefox 134 #607

cyril-sf opened this issue Jan 10, 2025 · 0 comments · May be fixed by #606

Comments

@cyril-sf
Copy link

Describe the bug
When trying to reorder items in a vertical collection on Firefox 134, the selected item remains at its original position once dropped

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Ember Sortable Demo with Firefox 134
  2. Try to reorder the Zero item between Two and Three
  3. See error

Expected behavior
Zero can be positioned between Two and Three

Screenshots
Screenshot 2025-01-10 at 2 45 22 PM
Notice how there is no space to drop the selected item

Additional context
We tracked down the root cause and it's linked to a change of behavior in Firefox 134. We opened an issue in Bugzilla

getComputedStyle returns a single length when horizontal and vertical have the same value on Firefox 134, no any other browser or older Firefox version. Because of this, getBorderSpacing (addon/src/utils/css-calculation.ts) returns undefined as vertical value. The height of a sortable item ends up being NaN.

We have a fix available if you're interested yapplabs@c4e04e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant