Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.adoptopenjdk.test.bigdecimal needs adjusting for jdk20+ #482

Closed
jiekang opened this issue Mar 16, 2023 · 1 comment
Closed

net.adoptopenjdk.test.bigdecimal needs adjusting for jdk20+ #482

jiekang opened this issue Mar 16, 2023 · 1 comment

Comments

@jiekang
Copy link
Contributor

jiekang commented Mar 16, 2023

Deep history shows consistent failures in bigdecimal for jdk 20:

https://trss.adoptium.net/deepHistory?testId=640da3e717052c6715411dd9

Examining three of those failures, I noticed in the sources there is a if-case separating jdk version 13+:

E.g. https://github.com/adoptium/aqa-systemtest/blob/0eb9f57f198fe194c070295c261e8bafeaed08aa/openjdk.test.math/src/test.math/net/adoptopenjdk/test/bigdecimal/TestSuite017.java

Then looking at BigDecimal sources, I noticed a change for jdk20 that suggests we should expect the behavior in jdk20 to match jdk11 again:

Latest commit of file: https://github.com/openjdk/jdk20/blob/master/test/jdk/java/math/BigDecimal/MovePointTests.java
Points to: https://bugs.openjdk.org/browse/JDK-8289260

This matches all three test cases I examined which failed when testing movePointLeft or movePointRight

I did not look deeply at every single failure in the deep history though; the failures are a different test case in every run which is curious; I guess the order of tests is random. Does it fail-fast?

@sophia-guo
Copy link
Contributor

Close by #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants