-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude jdk_jfr target on platforms where there are multitudes of failures #3636
Comments
Just a note there are around 430 tests under jdk/jfr and there are around 20 failures specific to 32 bit platform jdk8. |
hmm... perhaps it is too aggressive to remove the entire target then... I just noted that jdk_jfr is not tier1 or tier2 but rather tier3 (in jdk_svc), but that is in jdk_stable... (of note, some jfr tests require g1 gc and I have not looked closely at the list to see if this is correlated with the failures we have seen) |
require g1 gc is defined in jdk11+ and we don't have issue with those tests for jdk11+ for all platforms. Part of test failures mentioned in jdk_jfr_2 fail on jdk8 arm32 linux are mentioned in require g1 gc. There are some other jfr test failures per platform and jdk version, which is different from and less than jdk8 32 bit. |
We have decided to do this on a per testcase basis, rather than the entire block of testcases defined in the target. |
Given that jdk_jfr tests do not run well on certain platforms, like arm32 (or win32?), rather than exclude 10s of testcases, we will exclude the entire target on those platforms. So, if there are more than 5 testcases failing out of the set, we should consider this approach, otherwise we just exclude via ProblemList.
It appears as though the tests were not well tested on those platforms, but we need to confirm if they are ever met to be run there (and if not, lobby to exclude specific tests upstream).
The text was updated successfully, but these errors were encountered: