Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move get functional test material(openj9 tests) to functional/build.xml #5838

Open
sophia-guo opened this issue Jan 6, 2025 · 1 comment

Comments

@sophia-guo
Copy link
Contributor

In aqa-tests we have openjdk, system, perf, external, functional tests category. Each test category follows a similar structure and manage its own test material, i.e. with build.xml to gather test material ( git clone, curl, wget). This approach ensures simplicity, extensibility and low coupling.

Functional tests ( openj9 tests) are gathered differently getFunctionalTestMaterial() in get.sh by passing in extra parameters, which due to initially TKG was part of openj9. As TKG has its own repo it's time to move this process to functional/build.xml. This way when a new feature is enabled functional tests won't need to be considered differently, which might be missed, need extra tests and costs more. For example adoptium/TKG#651

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Jan 6, 2025

This could also make adding a functional/test.properties with openj9 repo and sha info possible #5151, which can avoid piling all infos to aqa-tests/testenv/testenv.properties and keep the file growing and choatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant