Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve temurin special case is not handled on the caller side ? #441

Open
karianna opened this issue Feb 21, 2022 · 0 comments
Open

Improve temurin special case is not handled on the caller side ? #441

karianna opened this issue Feb 21, 2022 · 0 comments

Comments

@karianna
Copy link
Contributor

@sxa, @karianna Why this special case is not handled on the caller side ?
temurin is not a JVM so the JVM arg must not accept "temurin" and hide some other value behind ..

If you set upsteam a vendor name temurin , his place is in VENDOR_BRANDING from this script, not in JVM arg

I think in caller job you must do somthing like that:
if (VARIANT == "temurin" )
VENDOR_BRANDING"=Temurin"
JVM="hotspot" // default JVM for VARIANT "temurin"
call createInstallerJob
fi

Originally posted by @douph1 in #438 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant