Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSuSE 15.5 as a supported distribution #793

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 12, 2024

This is in draft while it's undergoing testing, but this adds support for OpenSuSE 15.5 - the current verison - into our packaging process to ensure that users using that distribution can follow the installation instructions without modification on the latest patch level. Note that this also adjusts the process to build the package on OpenSuSE 15.5 instead of 15.4 as the base image.

Potential alternative options:

  • Add 15.6 which is available alpha for OpenSuSE
  • Remove 15.3 (out of support Dec 2022) to keep the number of distributions at 2, and potentially also rmove 15.4 since that is also out of support as of December 2023

Draft until I ensure it can be built successfully.

Fixes #792

@sxa sxa self-assigned this Jan 12, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@sxa sxa changed the title Add OpenSuSE 15.5 as a support distribution Add OpenSuSE 15.5 as a supported distribution Jan 12, 2024
Signed-off-by: Stewart X Addison <[email protected]>
@sxa
Copy link
Member Author

sxa commented Jan 12, 2024

Failure when trying to test this as per https://adoptium.slack.com/archives/C9C272Z1T/p1705070159433229 even with the :

packaging.ZypperOperationsTest.packageSuccessfullyInstalled(String, String)[1] STANDARD_ERROR
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

but since the process seemed to create the rpm file successfully with this change and I've verified they install ok on 15.3 I'm going to mark it as ready for review.

@sxa sxa marked this pull request as ready for review January 12, 2024 16:02
@karianna
Copy link
Contributor

@sxa does this need merging for the release?

@sxa
Copy link
Member Author

sxa commented Jan 13, 2024

@sxa does this need merging for the release?

I'm always nervous about putting changes in this close so I@ve been wavering, but I think it makes sense in this case since I'd expect most people using that distribution to be on 15SP5.

I believe @steelhead31 has confirmed that it seems to run through out processes ok (Link) and I've confirmed that the built package can still install on 15.3 so my gut feel is to try and get it in now I reckon (but since it's the weekend I was going to leave the PMC approval til Monday but 🤷🏻 )

@karianna
Copy link
Contributor

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@sxa
Copy link
Member Author

sxa commented Jan 14, 2024

/approve

1 similar comment
@smlambert
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review January 14, 2024 15:45

Thank you @sxa and @smlambert for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit 8437e62 into adoptium:master Jan 15, 2024
7 checks passed
@sxa
Copy link
Member Author

sxa commented Jan 15, 2024

Thank you @karianna!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

OpenSuSE repository does not include 15.5
3 participants