Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReproducibleCompare tests won't be triggered as dev.system #3674

Closed
sophia-guo opened this issue Feb 28, 2024 · 1 comment · Fixed by #3675 or adoptium/ci-jenkins-pipelines#956
Closed
Assignees
Labels
testing Issues that enhance or fix our test suites

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Feb 28, 2024

ReproducibleCompare tests won't be triggered as dev.system as it locates under functional/ folder.
https://ci.adoptium.net/job/Test_openjdk21_hs_dev.system_x86-64_linux/6/consoleFull
15:19:20 [echo] build.list is TestConfig/build.xml,system/build.xml

As discussed in #3587 we'd like move reproducible compare tests from dev.functional to dev.system but forgot the group is folder related.

If we'd like to keep those tests as system we need to move those tests to system/ folder under https://github.com/adoptium/temurin-build/tree/master/test @smlambert ?

@sophia-guo sophia-guo self-assigned this Feb 28, 2024
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Feb 28, 2024
@smlambert
Copy link
Contributor

Yes, while is not strictly necessary, it definitely helps make it clear where tests are categorized so please do move to a tests/system folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues that enhance or fix our test suites
Projects
No open projects
Status: Done
2 participants